RFR(XS): 8138896: C1: NativeGeneralJump is mixed up with NativeCall in C1 patching code

[Doerr, Martin]

Thank you very much for reviewing and sponsoring.

Best regards,
  Martin

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Mittwoch, 25. November 2015 12:25
To: Doerr, Martin <martin.doerr at sap.com>
Cc: hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR(XS): 8138896: C1: NativeGeneralJump is mixed up with NativeCall in C1 patching code

Looks good to me as well.

Will push it later this week.

Best regards,
Vladimir Ivanov

On 11/24/15 10:04 PM, Christian Thalinger wrote:
>
>> On Nov 23, 2015, at 12:44 AM, Doerr, Martin <martin.doerr at sap.com
>> <mailto:martin.doerr at sap.com>> wrote:
>>
>> Hi,
>> I have a webrev to clean up the usage of NativeGeneralJump where it is
>> required. Seems like on other platforms than PPC64 NativeGeneralJump
>> and NativeCall have the same size, so it is working by chance.
>> This change is a prerequisite for our C1 on PPC64 contribution where
>> we observed crashes due to this bug.
>> The webrev is here:
>> http://cr.openjdk.java.net/~mdoerr/8138896_c1_patching_fix/webrev.00/
>> @Christian:
>> You already had a look at it. Can I consider it as reviewed?
>
> Yes, reviewed.
>
>> I will also need a sponsor, please.
>> Best regards,
>>   Martin
>