[9] RFR(S): 8138651: -XX:DisableIntrinsic matches intrinsics overly eagerly

[Aleksey Shipilev]

On 10/06/2015 03:00 PM, Zoltán Majó wrote:
> https://bugs.openjdk.java.net/browse/JDK-8138651
> 
> Problem: The DisableIntrinsic flag does not disable intrinsics
> accurately. For example, -XX:DisableIntrinsic=_copyOfRange disables both
> the intrinsic with the ID _copyOfRange and the intrinsic with the _copyOf.
> 
> Solution: Change the processing of the DisableIntrinsic flag (both
> globally and on a per-method level).
> 
> Webrev: http://cr.openjdk.java.net/~zmajo/8138651/webrev.00/

Thanks for fixing this annoyance, Zoltan!

The patch looks good to me. A few comments:

 * Why do you need a copy of the list? Can't strtok operate on ccstr itself?

 * I think this collides with Nil's CompilerControl JEP a bit, that
apparently moved/redone this part of compiler.

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151006/89400856/signature.asc>