[9] RFR(S): 8138651: -XX:DisableIntrinsic matches intrinsics overly eagerly

[Zoltán Majó]

Hi Aleksey,


On 10/06/2015 03:05 PM, Aleksey Shipilev wrote:
> On 10/06/2015 03:00 PM, Zoltán Majó wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8138651
>>
>> Problem: The DisableIntrinsic flag does not disable intrinsics
>> accurately. For example, -XX:DisableIntrinsic=_copyOfRange disables both
>> the intrinsic with the ID _copyOfRange and the intrinsic with the _copyOf.
>>
>> Solution: Change the processing of the DisableIntrinsic flag (both
>> globally and on a per-method level).
>>
>> Webrev: http://cr.openjdk.java.net/~zmajo/8138651/webrev.00/
> Thanks for fixing this annoyance, Zoltan!

thank for the feedback.

>
> The patch looks good to me. A few comments:
>
>   * Why do you need a copy of the list? Can't strtok operate on ccstr itself?

No, it can't, because it modifies the list.

>
>   * I think this collides with Nil's CompilerControl JEP a bit, that
> apparently moved/redone this part of compiler.

Thank you for pointing that out. I've adapted the code to the changes 
done by compiler control. Please see the updated webrev in my reply to 
Vladimir.

Thank you and best regards,


Zoltan


>
> Thanks,
> -Aleksey
>
>