RFR(S): 8138890: C1: Ambiguous operator delete

[Lindenmaier, Goetz]

Hi,

As I remember we drilled down the issue in allocation.hpp to the attached test, which compiles
with gcc but not with xlC.  And the test still does not compile.  IBM stated that that is incorrect
C++.

Martin, you can now remove the second 'private:'.
And we wondered why no implementation is needed for the operators.

Best regards,
  Goetz.


-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Mikael Gerdin
Sent: Mittwoch, 7. Oktober 2015 16:56
To: Doerr, Martin; Christian Thalinger
Cc: hotspot compiler
Subject: Re: RFR(S): 8138890: C1: Ambiguous operator delete

On 2015-10-07 16:17, Doerr, Martin wrote:
> Hi,
>
> that's a good question J
>
> I can only remember that there were problems with some old compilers.
>
> Anyway, xlC 12.1 can deal with the private delete operators.

If that's the case, can we also get rid of the workaround in allocation.hpp?

Thanks
/Mikael

>
> Here's the new webrev:
>
> http://cr.openjdk.java.net/~mdoerr/8138890_c1_ambiguous_delete/webrev.01
>
> Best regards,
>
>    Martin
>
> *From:*Christian Thalinger [mailto:christian.thalinger at oracle.com]
> *Sent:* Mittwoch, 7. Oktober 2015 03:32
> *To:* Doerr, Martin
> *Cc:* hotspot compiler
> *Subject:* Re: RFR(S): 8138890: C1: Ambiguous operator delete
>
>     On Oct 6, 2015, at 3:56 AM, Doerr, Martin <martin.doerr at sap.com
>     <mailto:martin.doerr at sap.com>> wrote:
>
>     Hi,
>
>     xlC on AIX rejects to compile LIRGenerator and
>     RangeCheckEliminator::Verification due to ambiguous operator delete
>     which gets inherited from multiple base classes.
>
>     This change is a prerequisite for our C1 on PPC64 contribution.
>
>     Webrev is here:
>
>     http://cr.openjdk.java.net/~mdoerr/8138890_c1_ambiguous_delete/webrev.00
>
> Let me ask my question here:  why do you need the delete methods to be
> public on AIX?
>
>
>
> Please review this change.  I need a sponsor, please.
>
> Best regards,
>
>    Martin
>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test.cpp
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151007/2c68d2c1/test.cpp>