RFR(S): 8138890: C1: Ambiguous operator delete

[Doerr, Martin]

Hi Mikael,

unfortunately, the answer is no.
1540-0300 (S) The "private" member "StackObj::operator delete(void *)" cannot be accessed.

However, the C1 files were ok without it.

Best regards,
  Martin

-----Original Message-----
From: Mikael Gerdin [mailto:mikael.gerdin at oracle.com] 
Sent: Mittwoch, 7. Oktober 2015 16:56
To: Doerr, Martin; Christian Thalinger
Cc: hotspot compiler
Subject: Re: RFR(S): 8138890: C1: Ambiguous operator delete

On 2015-10-07 16:17, Doerr, Martin wrote:
> Hi,
>
> that's a good question J
>
> I can only remember that there were problems with some old compilers.
>
> Anyway, xlC 12.1 can deal with the private delete operators.

If that's the case, can we also get rid of the workaround in allocation.hpp?

Thanks
/Mikael

>
> Here's the new webrev:
>
> http://cr.openjdk.java.net/~mdoerr/8138890_c1_ambiguous_delete/webrev.01
>
> Best regards,
>
>    Martin
>
> *From:*Christian Thalinger [mailto:christian.thalinger at oracle.com]
> *Sent:* Mittwoch, 7. Oktober 2015 03:32
> *To:* Doerr, Martin
> *Cc:* hotspot compiler
> *Subject:* Re: RFR(S): 8138890: C1: Ambiguous operator delete
>
>     On Oct 6, 2015, at 3:56 AM, Doerr, Martin <martin.doerr at sap.com
>     <mailto:martin.doerr at sap.com>> wrote:
>
>     Hi,
>
>     xlC on AIX rejects to compile LIRGenerator and
>     RangeCheckEliminator::Verification due to ambiguous operator delete
>     which gets inherited from multiple base classes.
>
>     This change is a prerequisite for our C1 on PPC64 contribution.
>
>     Webrev is here:
>
>     http://cr.openjdk.java.net/~mdoerr/8138890_c1_ambiguous_delete/webrev.00
>
> Let me ask my question here:  why do you need the delete methods to be
> public on AIX?
>
>
>
> Please review this change.  I need a sponsor, please.
>
> Best regards,
>
>    Martin
>