RFR (S) 8134758: Final String field values should be trusted as stable

[Aleksey Shipilev]

On 09/01/2015 06:36 PM, Vladimir Kozlov wrote:
> On 9/1/15 4:34 AM, Aleksey Shipilev wrote:
>> On 09/01/2015 04:31 AM, Vladimir Kozlov wrote:
>>> Why you check constant.basic_type() == T_OBJECT?
>>> In old compact strings version it was value field's type but now it is
>>> always array.
>>
>> Because that line of reasoning got us here: the desynced version that
>> gets overlooked for months in Compact String research, and wastes more
>> time after the flaw is discovered. I'd prefer to handle all final fields
>> in Strings universally, for every possible type, to avoid future
>> surprises.
> 
> Okay, may be add comment.

Sure, I don't see why not:
  http://cr.openjdk.java.net/~shade/8134758/webrev.02/

Thanks,
-Aleksey



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150901/b217b4b3/signature.asc>