RFR (S) 8134758: Final String field values should be trusted as stable

[Vladimir Kozlov]

Looks good.

Thanks,
Vladimir

On 9/1/15 9:01 AM, Aleksey Shipilev wrote:
> On 09/01/2015 06:36 PM, Vladimir Kozlov wrote:
>> On 9/1/15 4:34 AM, Aleksey Shipilev wrote:
>>> On 09/01/2015 04:31 AM, Vladimir Kozlov wrote:
>>>> Why you check constant.basic_type() == T_OBJECT?
>>>> In old compact strings version it was value field's type but now it is
>>>> always array.
>>>
>>> Because that line of reasoning got us here: the desynced version that
>>> gets overlooked for months in Compact String research, and wastes more
>>> time after the flaw is discovered. I'd prefer to handle all final fields
>>> in Strings universally, for every possible type, to avoid future
>>> surprises.
>>
>> Okay, may be add comment.
>
> Sure, I don't see why not:
>    http://cr.openjdk.java.net/~shade/8134758/webrev.02/
>
> Thanks,
> -Aleksey
>
>
>