RFR(XS): 8163533: jdk.vm.ci.hotspot.test.MethodHandleAccessProviderTest fails on jdk9/dev

Aleksey Shipilev aleksey.shipilev at gmail.com
Thu Aug 11 21:09:33 UTC 2016


On 08/11/2016 11:55 PM, Michael Haupt wrote:
> please review this fix.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8163533
> Webrev: http://cr.openjdk.java.net/~mhaupt/8163533/webrev.00/

Yes, obvious-in-hindsight mistake. The fix looks good.

I would guess the original change would not fall victim to this if it
had used Signature as the argument, instead of the exploded
resultType+parameterTypes pair -- which enables using Signature.equals()
instead of hand-rolled signatureMatches():
  http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/f4c6ee42184c#l1.56

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160812/9cb3cfb3/signature-0001.asc>


More information about the hotspot-compiler-dev mailing list