RFR(XS): 8163533: jdk.vm.ci.hotspot.test.MethodHandleAccessProviderTest fails on jdk9/dev

[Michael Haupt]

Hi Aleksey,

thank you. That is a worthwhile suggestion that I'd like to take up: http://cr.openjdk.java.net/~mhaupt/8163533/webrev.01/ - please review. I've started the test job for this change and will push once both your review and the results are in.

Thanks,

Michael

> Am 11.08.2016 um 14:09 schrieb Aleksey Shipilev <aleksey.shipilev at gmail.com>:
> 
> On 08/11/2016 11:55 PM, Michael Haupt wrote:
>> please review this fix.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8163533
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8163533/webrev.00/
> 
> Yes, obvious-in-hindsight mistake. The fix looks good.
> 
> I would guess the original change would not fall victim to this if it
> had used Signature as the argument, instead of the exploded
> resultType+parameterTypes pair -- which enables using Signature.equals()
> instead of hand-rolled signatureMatches():
>  http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/f4c6ee42184c#l1.56
> 
> Thanks,
> -Aleksey
> 
> 

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160811/32146a1a/attachment.html>