RFR(XS): 8170886 - compiler/ciReplay/TestSAServer.java intermittently throws NumberFormatException

Tobias Hartmann tobias.hartmann at oracle.com
Thu Dec 15 17:35:26 UTC 2016


Hi Dmitrij,

On 15.12.2016 18:24, Dmitrij Pochepko wrote:
> Hi,
> 
> please review small fix for 8170886 - compiler/ciReplay/TestSAServer.java intermittently throws NumberFormatException
> 
> Test has thrown NFE once, because of replay file parsing logic of this test couldn't handle case of inlining information present.
> 
> Test expected 6th column to be last, which is true for non-inlining case only. This fix modifies logic to specifically get 6th column of compilation string instead of "last" column.
> 
> webrev: http://cr.openjdk.java.net/~dpochepk/8170886/webrev.01/

Looks good to me!

Thanks,
Tobias

> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8170886
> 
> I've tested it on linux-x64.
> 
> Thanks,
> 
> Dmitrij
> 


More information about the hotspot-compiler-dev mailing list