RFR(M): 8171398: s390x: Make interpreter's math entries consistent with C1 and C2 and support FMA

[Doerr, Martin]

Hi,

thanks, Vladimir, for your support. Especially for pushing my PPC64 change.

Thanks, everyone, for reviewing.

Best regards,
Martin


-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Dienstag, 20. Dezember 2016 10:14
To: Schmidt, Lutz <lutz.schmidt at sap.com>; Doerr, Martin <martin.doerr at sap.com>; 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: RFR(M): 8171398: s390x: Make interpreter's math entries consistent with C1 and C2 and support FMA

Hi Martin,

It could be pushed directly (after review) since it has only s390 changes.

Thanks,
Vladimir

On 12/19/16 7:57 AM, Schmidt, Lutz wrote:
> Hi Martin,
>
> your change looks good. I have one minor suggestions, though.
>
>  - in s390.ad: please adapt comments in all "instruct msub*" to say 
> "CC unchanged by MUL-SUB"
>
> Thanks,
> Lutz
>
>
> From: hotspot-compiler-dev
> <hotspot-compiler-dev-bounces at openjdk.java.net
> <mailto:hotspot-compiler-dev-bounces at openjdk.java.net>> on behalf of 
> "Doerr, Martin (martin.doerr at sap.com <mailto:martin.doerr at sap.com>)"
> <martin.doerr at sap.com <mailto:martin.doerr at sap.com>>
> Date: Samstag, 17. Dezember 2016 um 11:18
> To: "'hotspot-compiler-dev at openjdk.java.net
> <mailto:'hotspot-compiler-dev at openjdk.java.net>'"
> <hotspot-compiler-dev at openjdk.java.net
> <mailto:hotspot-compiler-dev at openjdk.java.net>>
> Subject: RFR(M): 8171398: s390x: Make interpreter's math entries 
> consistent with C1 and C2 and support FMA
>
> Hi,
>
>
>
> I'd like to address the same issue as on PPC64 on s390x.
>
> As discussed in [1], floating point computations should produce 
> consistent results regardless of whether the Java code gets 
> interpreted or is compiled by any JIT-compiler.
>
> In addition, JDK9 introduced new floating point multiply-accumulate 
> intrinsics which are currently missing on s390x.
>
>
>
> Webrev is here:
>
> http://cr.openjdk.java.net/~mdoerr/8171398_s390_FMA/webrev.00/
>
>
>
> I have included a bugfix for parameter handling in an aes decrypt stub.
>
>
>
> Please review.
>
>
>
> Best regards,
>
> Martin
>
>
>
>
>
> [1]
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-Decem
> ber/025073.html
>
>
>