[9] RFR(XS): 8147444: compiler/jsr292/NonInlinedCall/RedefineTest.java fails with NullPointerException in ClassFileInstaller

[Tobias Hartmann]

Thanks, Vladimir.

On 15.01.2016 13:40, Vladimir Ivanov wrote:
> Looks good. Thanks for fixing it!
> 
> BTW can ClassFileInstaller be improved to check the input and report the problem in a meaningful way? NPE is useless when diagnosing such problems.

Sure, I changed the implementation to throw an exception:
 Execution failed: `main' threw exception: java.io.FileNotFoundException: jdk/test/lib/Asserts.class

http://cr.openjdk.java.net/~thartmann/8147444/webrev.01/

Best,
Tobias

> 
> Best regards,
> Vladimir Ivanov
> 
> On 1/15/16 2:07 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8147444
>> http://cr.openjdk.java.net/~thartmann/8147444/webrev.00/
>>
>> The test compiler/jsr292/NonInlinedCall/RedefineTest.java fails in the ClassFileInstaller while trying to install jdk.test.lib.Asserts because the class is not imported and therefore not compiled. Because asserts are not used in this test, I removed the directive.
>>
>> Thanks,
>> Tobias
>>