RFR: 8161265: [JVMCI] EnableJVMCI should only be required when its not implied by other flags

Tom Rodriguez tom.rodriguez at oracle.com
Fri Jul 15 00:22:23 UTC 2016


>> 
>> This is super painful; even more for you than me :-)
> 
> The only thing that makes it painful is that openjdk is still on 20 year old code reviewing technology.
> 
>> With your changes what happens if you do:
>> 
>> -XX:+UseJVMCICompiler -XX:-EnableJVMCI
> 
> At the moment, it ignores the latter which is probably going to surprise someone. This fixes it:
> 
> http://cr.openjdk.java.net/~dnsimon/8161265.v3/index.html <http://cr.openjdk.java.net/~dnsimon/8161265.v3/index.html>
> 
> -Doug

That looks good to me.  Thanks for fixing this.

tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160714/2b1b5b37/attachment.html>


More information about the hotspot-compiler-dev mailing list