RFR: 8161265: [JVMCI] EnableJVMCI should only be required when its not implied by other flags
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Jul 19 00:27:44 UTC 2016
Very nice cleanup. I assume it passed all tests.
Thanks,
Vladimir
On 7/14/16 5:22 PM, Tom Rodriguez wrote:
>>>
>>> This is super painful; even more for you than me :-)
>>
>> The only thing that makes it painful is that openjdk is still on 20
>> year old code reviewing technology.
>>
>>> With your changes what happens if you do:
>>>
>>> -XX:+UseJVMCICompiler -XX:-EnableJVMCI
>>
>> At the moment, it ignores the latter which is probably going to
>> surprise someone. This fixes it:
>>
>> http://cr.openjdk.java.net/~dnsimon/8161265.v3/index.html
>>
>> -Doug
>
> That looks good to me. Thanks for fixing this.
>
> tom
More information about the hotspot-compiler-dev
mailing list