RFR: 8155023: jdk.vm.ci needs to securely export services

Christian Thalinger christian.thalinger at oracle.com
Wed May 4 19:13:55 UTC 2016


> On May 3, 2016, at 3:34 AM, Doug Simon <doug.simon at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8155023
> http://cr.openjdk.java.net/~dnsimon/8155023/
src/jdk.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java

- * Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
Why did you remove 2014?

src/jdk.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java

+    /**
      * Gets an {@link Iterable} of the JVMCI providers available for a given service.
+
+     * @throws SecurityException if a security manager is present and it denies
+     *             {@code RuntimePermission("jvmci")}
      */
     public static <S> Iterable<S> load(Class<S> service) {
+        Module jvmci = Services.class.getModule();
+        jvmci.addUses(service);
         return ServiceLoader.load(service);
     }
Where is the SecurityException thrown?  Also, there is a “*” missing in the JavaDoc.

src/jdk.vm.ci/share/classes/module-info.java

+    // 8153756
+    requires jdk.unsupported;
Why is this back?

> 
> -Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160504/95a55c2a/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list