RFR: 8155023: jdk.vm.ci needs to securely export services

[Doug Simon]

> On 04 May 2016, at 21:13, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> 
>> On May 3, 2016, at 3:34 AM, Doug Simon <doug.simon at oracle.com> wrote:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8155023
>> http://cr.openjdk.java.net/~dnsimon/8155023/
> src/jdk.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java
> 
> - * Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
> Why did you remove 2014?

Oversight - I restored it.

> 
> src/jdk.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java
> 
> +    /**
> 
>       * Gets an {@link Iterable} of the JVMCI providers available for a given service.
> 
> +
> +     * @throws SecurityException if a security manager is present and it denies
> +     *             {@code RuntimePermission("jvmci")}
> 
>       */
>      public static <S> Iterable<S> load(Class<S> service) {
> 
> +        Module jvmci = Services.class.getModule();
> +        jvmci.addUses(service);
> 
>          return ServiceLoader.load(service);
>      }
> 
> Where is the SecurityException thrown?  Also, there is a “*” missing in the JavaDoc.

Security checks got lost in refactoring - restored.
Missing “*” added.

> 
> src/jdk.vm.ci/share/classes/module-info.java
> 
> +    // 8153756
> +    requires jdk.unsupported;
> Why is this back?

Merge error. Fixed.

Thanks for catching these issues. I’ve updated the webrev in situ.

I also noticed that I removed --with-native-debug-symbols in the configure command issued in .mx_jvmci/mx_jvmci.py where as I meant to change it to --with-native-debug-symbols=external. I also fixed that in situ.

-Doug