RFR 8152343: JVMCI test tasks: Unit tests for MetaAccessProvider
Christian Thalinger
christian.thalinger at oracle.com
Fri May 6 21:28:40 UTC 2016
> On May 6, 2016, at 4:25 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
>
> Hi,
>
> please review patch for 8152343: JVMCI test tasks: Unit tests for MetaAccessProvider
>
> A new tests were added for jdk.vm.ci.meta.MetaAccessProvider implementation. An existing TestMetaAccessProvider.java was used to add new tests.
>
> webrev: http://cr.openjdk.java.net/~dpochepk/8152343/webrev.01/
+ private static final int[] VALID_ENCODED_VALUES = new int[]{-180, -436, -10932, -2147483572};
What are these values? Maybe it would make more sense to have them in hex-form?
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8152343
>
> I've tested it on linux_x64.
>
> Thanks,
> Dmitrij
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160506/3dcc8cda/attachment.html>
More information about the hotspot-compiler-dev
mailing list