RFR(S): 8156025: [JVMCI] make HotSpotResolvedObjectTypeImpl.createField non-public

[Roland Schatz]

On 05/06/2016 11:19 PM, Christian Thalinger wrote:
>> On May 5, 2016, at 11:18 PM, Roland Schatz <roland.schatz at oracle.com> wrote:
>>
>> On 05/04/2016 09:20 PM, Christian Thalinger wrote:
>>>> On May 4, 2016, at 3:48 AM, Roland Schatz <roland.schatz at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review:
>>>> http://cr.openjdk.java.net/~rschatz/JDK-8156025/webrev.00/hotspot.changeset
>>>> https://bugs.openjdk.java.net/browse/JDK-8156025
>>>>
>>>> This method is used only internally, it should never have been public.
>>> Looks good.  All JVMCI tests pass?
>> At least no new failures, as far as I can tell.
>>
>> Looks like quite a few are failing anyway on the current tip.
>>> Test results: passed: 43; failed: 26; error: 5
>> Or am I doing something wrong running the test?
> You must be doing something wrong.  How are you running them?  Also, use -ignore:quiet to not show the ignored tests (the errors).

Just tried that on current hs-comp tip (clean rebuild, i.e. "rm -rf 
build JTwork JTreport; bash configure; make"):

> [roland at oracle-rs hs-comp]$ ~/jtreg/bin/jtreg -testjdk 
> build/linux-x86_64-normal-server-release/jdk -ignore:quiet 
> hotspot/test/compiler/jvmci
> Directory "JTwork" not found: creating
> Directory "JTreport" not found: creating
> Test results: passed: 43; failed: 26
> Report written to /home/roland/hg/jdk9/hs-comp/JTreport/html/report.html
> Results written to /home/roland/hg/jdk9/hs-comp/JTwork
> Error: Some tests failed or other problems occurred.



>
>>
>> - Roland