RFR(S): 8156025: [JVMCI] make HotSpotResolvedObjectTypeImpl.createField non-public

[Christian Thalinger]

> On May 8, 2016, at 11:28 PM, Roland Schatz <roland.schatz at oracle.com> wrote:
> 
> On 05/06/2016 11:19 PM, Christian Thalinger wrote:
>>> On May 5, 2016, at 11:18 PM, Roland Schatz <roland.schatz at oracle.com> wrote:
>>> 
>>> On 05/04/2016 09:20 PM, Christian Thalinger wrote:
>>>>> On May 4, 2016, at 3:48 AM, Roland Schatz <roland.schatz at oracle.com> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> Please review:
>>>>> http://cr.openjdk.java.net/~rschatz/JDK-8156025/webrev.00/hotspot.changeset
>>>>> https://bugs.openjdk.java.net/browse/JDK-8156025
>>>>> 
>>>>> This method is used only internally, it should never have been public.
>>>> Looks good.  All JVMCI tests pass?
>>> At least no new failures, as far as I can tell.
>>> 
>>> Looks like quite a few are failing anyway on the current tip.
>>>> Test results: passed: 43; failed: 26; error: 5
>>> Or am I doing something wrong running the test?
>> You must be doing something wrong.  How are you running them?  Also, use -ignore:quiet to not show the ignored tests (the errors).
> 
> Just tried that on current hs-comp tip (clean rebuild, i.e. "rm -rf build JTwork JTreport; bash configure; make"):
> 
>> [roland at oracle-rs hs-comp]$ ~/jtreg/bin/jtreg -testjdk build/linux-x86_64-normal-server-release/jdk -ignore:quiet hotspot/test/compiler/jvmci
>> Directory "JTwork" not found: creating
>> Directory "JTreport" not found: creating
>> Test results: passed: 43; failed: 26
>> Report written to /home/roland/hg/jdk9/hs-comp/JTreport/html/report.html
>> Results written to /home/roland/hg/jdk9/hs-comp/JTwork
>> Error: Some tests failed or other problems occurred.

That is really odd.  Oh, that’s the exploded JDK; somehow it doesn’t work:

java.lang.NoClassDefFoundError: jdk/vm/ci/hotspot/HotSpotResolvedJavaMethod
	at compiler.jvmci.compilerToVM.AllocateCompileIdTest.runSanityCorrectTest(AllocateCompileIdTest.java:126)
	at java.util.ArrayList.forEach(java.base/ArrayList.java:1352)
	at compiler.jvmci.compilerToVM.AllocateCompileIdTest.main(AllocateCompileIdTest.java:72)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(java.base/Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(java.base/NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(java.base/DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(java.base/Method.java:531)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:110)
	at java.lang.Thread.run(java.base/Thread.java:843)
Caused by: java.lang.ClassNotFoundException: jdk.vm.ci.hotspot.HotSpotResolvedJavaMethod
	at jdk.internal.loader.BuiltinClassLoader.loadClass(java.base/BuiltinClassLoader.java:366)
	at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(java.base/ClassLoaders.java:184)
	at java.lang.ClassLoader.loadClass(java.base/ClassLoader.java:419)
	... 9 more

Build the image and use that.

> 
> 
> 
>> 
>>> 
>>> - Roland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160509/63d974b6/attachment-0001.html>