RFR(M): 8166561: [s390] Adaptions needed for s390 port in C1 and C2.
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Thu Oct 13 14:34:25 UTC 2016
Hi,
I had to add a tiny patch to this change. It had sneaked into
another patch in my mq. See the incremental diff below.
New webrev:
http://cr.openjdk.java.net/~goetz/wr16/8166561-basic_C1C2_s390/webrev.04/
Best regards,
Goetz.
--- a/src/share/vm/adlc/main.cpp Thu Sep 22 18:29:15 2016 +0200
+++ b/src/share/vm/adlc/main.cpp Thu Oct 13 16:25:13 2016 +0200
@@ -259,6 +259,7 @@
AD.addInclude(AD._DFA_file, "opto/cfgnode.hpp"); // Use PROB_MAX in predicate.
AD.addInclude(AD._DFA_file, "opto/intrinsicnode.hpp");
AD.addInclude(AD._DFA_file, "opto/matcher.hpp");
+ AD.addInclude(AD._DFA_file, "opto/narrowptrnode.hpp");
AD.addInclude(AD._DFA_file, "opto/opcodes.hpp");
AD.addInclude(AD._DFA_file, "opto/convertnode.hpp");
// Make sure each .cpp file starts with include lines:
> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Monday, October 10, 2016 11:18 AM
> To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: RE: RFR(M): 8166561: [s390] Adaptions needed for s390 port in C1
> and C2.
>
> Hi Vladimir,
>
> I removed the line, and I also adapted the copyrights:
> http://cr.openjdk.java.net/~goetz/wr16/8166561-
> basic_C1C2_s390/webrev.03/
>
> Best regards,
> Goetz.
>
> > -----Original Message-----
> > From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> > Sent: Donnerstag, 6. Oktober 2016 18:59
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> > dev at openjdk.java.net
> > Subject: Re: RFR(M): 8166561: [s390] Adaptions needed for s390 port in C1
> > and C2.
> >
> > Sorry, I forgot to say that you should not call
> > CompileBroker::handle_full_code_cache() in output.cpp. It is called
> > during maybe_expand_to_ensure_remaining() call.
> >
> > Thanks,
> > Vladimir
> >
> > On 10/5/16 11:03 PM, Lindenmaier, Goetz wrote:
> > > Hi Vladimir,
> > >
> > > I made the corresponding change. New webrev:
> > > http://cr.openjdk.java.net/~goetz/wr16/8166561-
> > basic_C1C2_s390/webrev.02/
> > >
> > > Thanks also for pushing 8166562!
> > >
> > > Best regards,
> > > Goetz.
> > >
> > >> -----Original Message-----
> > >> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> > >> Sent: Mittwoch, 5. Oktober 2016 19:36
> > >> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> > compiler-
> > >> dev at openjdk.java.net
> > >> Subject: Re: RFR(M): 8166561: [s390] Adaptions needed for s390 port in
> C1
> > >> and C2.
> > >>
> > >> Can you make IdealizeClearArrayNode diagnostic_pd flag? It could be
> > >> useful on other platforms to switch off optimization.
> > >>
> > >> Thanks,
> > >> Vladimir
> > >>
> > >> On 10/5/16 8:39 AM, Lindenmaier, Goetz wrote:
> > >>> Hi
> > >>>
> > >>>
> > >>>
> > >>> Please review this change needed for the s390 port.
> > >>>
> > >>> It adds all the shared configurations and some minor adaptions needed
> > >>>
> > >>> in the C1 and C2 compilers:
> > >>>
> > >>> http://cr.openjdk.java.net/~goetz/wr16/8166561-
> > >> basic_C1C2_s390/webrev.01/
> > >>>
> > >>>
> > >>>
> > >>> Best regards,
> > >>>
> > >>> Goetz.
> > >>>
> > >>>
> > >>>
More information about the hotspot-compiler-dev
mailing list