RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build

Andrew Haley aph at redhat.com
Wed Oct 26 09:51:30 UTC 2016


On 26/10/16 04:33, White, Derek wrote:
> Hi Ningsheng,
> 
> Thanks for catching that. 
> 
> I messed up, but the commit message title is correct. That *is* the title for bug ID JDK-8168567, but there's an error in the title of the bug :-)
> 
> Andrew, do you want me to fix both before checking in the fix?

Close but no cigar:

pushing to ssh://hg.openjdk.java.net/jdk9/hs/hotspot
searching for changes
remote: X11 forwarding request failed on channel 0
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: [jcheck d46eaf84b346 2015-12-01 13:15:54 -0800]
remote:
remote: > Changeset: 12236:8b56e1a63d6d
remote: > Author:    drwhite
remote: > Date:      2016-10-24 13:36
remote: >
remote: > 8168567: Fix for 8166972 breaks aarch64 build
remote: > Summary: Addded missing #endif for aarch64 code.
remote: > Reviewed by: kvn, aph
remote: > Contributed-by: Ningsheng Jian <ningsheng.jian at linaro.org>
remote:
remote: Incomplete comment: Missing reviewer attribution
remote: Extraneous text in comment
remote:
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.0.jcheck hook failed

You need to install jcheck in your local Hg.

Andrew.



More information about the hotspot-compiler-dev mailing list