[10] RFR: 8171813: possible null pointer dereference defects

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 3 06:22:57 UTC 2017


Hi Rahul,

On 31.03.2017 17:48, Rahul Raghavan wrote:
> Please review following patch proposal to avoid 
> possible null pointer dereference warnings / errors for internal tests.
> 
> <webrev.00> - http://cr.openjdk.java.net/~rraghavan/8171813/webrev.00/

Please compare against NULL instead of casting to bool, i.e. use "if (compiler != NULL)" instead of "if (compiler)".

In simpleThresholdPolicy.inline.hpp:80, please move the * to the type: use "AbstractCompiler* comp" instead of "AbstractCompiler *comp".

Thanks,
Tobias


More information about the hotspot-compiler-dev mailing list