[8u-dev] Request for approval for CR: 8165482: java in ldoms, with cpu-arch=generic has problems

[Kevin Walls]

Hi Poonam, thanks!


On 03/04/2017 14:41, Poonam Parhar wrote:
>
> Hello Kevin,
>
> The changes backported to 8u look fine to me.
>
> Thanks,
>
> Poonam
>
> *From:*Kevin Walls
> *Sent:* Saturday, April 01, 2017 2:40 AM
> *To:* hotspot-compiler-dev at openjdk.java.net
> *Subject:* Fwd: Re: [8u-dev] Request for approval for CR: 8165482: 
> java in ldoms, with cpu-arch=generic has problems
>
> Hi,
>
> I'd like to get a hotspot-compiler-dev code review on the change below...
>
> Many thanks,
> Kevin
>
> -------- Forwarded Message --------
>
> *Subject: *
>
> 	
>
> Re: [8u-dev] Request for approval for CR: 8165482: java in ldoms, with 
> cpu-arch=generic has problems
>
> *Date: *
>
> 	
>
> Fri, 31 Mar 2017 18:50:09 +0100
>
> *From: *
>
> 	
>
> Rob McKenna <rob.mckenna at oracle.com> <mailto:rob.mckenna at oracle.com>
>
> *To: *
>
> 	
>
> Kevin Walls <kevin.walls at oracle.com> <mailto:kevin.walls at oracle.com>
>
> *CC: *
>
> 	
>
> jdk8u-dev at openjdk.java.net <mailto:jdk8u-dev at openjdk.java.net>
>
> Hi Kevin,
> These changes will need codereview.
>      -Rob
> On 31/03/17 03:32, Kevin Walls wrote:
> > Hi,
> >
> > This is an approval request to backport into 8u:
> >
> > 8165482: java in ldoms, with cpu-arch=generic has problems
> > 9 changeset:http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/dfff5edc66df
> >
> > With a few routine changes this backports OK:
> >
> > src/cpu/sparc/vm/vm_version_sparc.cpp: has a different initial number of %s
> > in a call to jio_snprintf(), so it's not automatic, but the backport adds
> > one %s.
> >
> > src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp: in 8u we have an
> > #ifndef PRODUCT which isn't in 9, not part of the change, but means the diff
> > won't apply automatically.
> >
> > 9 uses log(), logging in 8u uses tty->print_cr, and needs err_msg() to form
> > a message rather than having printf-style formatting built-in.  8u also uses
> > #ifndef PRODUCT also, and in some places if (PrintMiscellaneous && Verbose)
> >
> > Webrev in 8u of these changes:
> >http://cr.openjdk.java.net/~kevinw/8165482.8u/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ekevinw/8165482.8u/webrev.00/>
> >
> > Thanks
> > Kevin
> >
> >
> >
> >

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20170403/d2d0c3d8/attachment.html>