RFR: 8173679: Disable ProfileTrap code and UseRTMLocking in emulated client Win32

Jamsheed C m jamsheed.c.m at oracle.com
Tue Jan 31 18:37:19 UTC 2017


Hi Vladimir,

ProfileTraps is develop_pd flag, should i be changing flag type ?

RTM test code doesn't pass VM options to  spawned  process, So predicate 
checking process and spawned process can be in different modes. spawned 
test process is always in emulated client mode in win32.

the predicate checking process will be in emulated client or server 
based on passed  -XX:+|-TieredCompilation option.  as a fix i disabled 
RTM testing completely in win32.

i will disable RTM completely in win32(both emulated client and server).

Best Regards,

Jamsheed

On 1/31/2017 11:15 PM, Vladimir Kozlov wrote:
> Jamsheed
>
> Instead of adding check && !is_client_compilation_mode_vm() I think we 
> should set ProfileTraps to false in client mode.
>
> Why you not using Platform.isEmulatedClient() in tests changes?
>
> Thanks,
> Vladimir
>
> On 1/31/17 2:44 AM, Jamsheed C m wrote:
>> Hi,
>>
>> Code change to disable ProfileTrap and UseRTMLocking in Win32 
>> emulated client .
>>
>> 1) ProfileTrap is code is disabled
>>
>> 2) -XX:+ UseRTMLocking in win32 emulated client not supported.
>>
>> 3) All Supported and Unsupported  testcases related RTM is disabled 
>> in win32.
>>
>> webrev: http://cr.openjdk.java.net/~jcm/8173679/webrev.00/
>>
>> bug id: https://bugs.openjdk.java.net/browse/JDK-8173679
>>
>> Best Regards,
>>
>> Jamsheed
>>



More information about the hotspot-compiler-dev mailing list