RFR: 8173679: Disable ProfileTrap code and UseRTMLocking in emulated client Win32

[Vladimir Kozlov]

On 1/31/17 10:37 AM, Jamsheed C m wrote:
> Hi Vladimir,
>
> ProfileTraps is develop_pd flag, should i be changing flag type ?

No. Thinking more about this. The code guarded by ProfileTraps should be only executed when ProfileInterpreter is true. 
And you set ProfileInterpreter to false in client mode. Why you need these changes then? Did you hit some ProfileTraps 
code which is not guarded by ProfileInterpreter?

>
> RTM test code doesn't pass VM options to  spawned  process, So predicate checking process and spawned process can be in
> different modes. spawned test process is always in emulated client mode in win32.
>
> the predicate checking process will be in emulated client or server based on passed  -XX:+|-TieredCompilation option.
> as a fix i disabled RTM testing completely in win32.

I still do not understand why you can't use Platform.isEmulatedClient() instead of Platform.isWindows() && 
Platform.is32bit().

And why changes in SupportedOS.java is not enough?

>
> i will disable RTM completely in win32(both emulated client and server).

I would suggest to disable RTM only in client mode.

Thanks,
Vladimir

>
> Best Regards,
>
> Jamsheed
>
> On 1/31/2017 11:15 PM, Vladimir Kozlov wrote:
>> Jamsheed
>>
>> Instead of adding check && !is_client_compilation_mode_vm() I think we should set ProfileTraps to false in client mode.
>>
>> Why you not using Platform.isEmulatedClient() in tests changes?
>>
>> Thanks,
>> Vladimir
>>
>> On 1/31/17 2:44 AM, Jamsheed C m wrote:
>>> Hi,
>>>
>>> Code change to disable ProfileTrap and UseRTMLocking in Win32 emulated client .
>>>
>>> 1) ProfileTrap is code is disabled
>>>
>>> 2) -XX:+ UseRTMLocking in win32 emulated client not supported.
>>>
>>> 3) All Supported and Unsupported  testcases related RTM is disabled in win32.
>>>
>>> webrev: http://cr.openjdk.java.net/~jcm/8173679/webrev.00/
>>>
>>> bug id: https://bugs.openjdk.java.net/browse/JDK-8173679
>>>
>>> Best Regards,
>>>
>>> Jamsheed
>>>
>