RFR(XS): 8214376: Don't use memset to initialize array of Bundle in output.cpp

Aleksey Shipilev shade at redhat.com
Fri Dec 7 14:36:17 UTC 2018


On 12/7/18 3:29 PM, Aleksey Shipilev wrote:
> On 12/7/18 2:32 PM, Dmitry Chuyko wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8214376
>> webrev: http://cr.openjdk.java.net/~dchuyko/8214376/webrev.00/
> 
> Looks fine.
> 
> I think we better break the lines:
> 	
>   for (uint i = 0; i < node_max; i++) {
>      ::new (&_node_bundling_base[i]) Bundle();
>   }

Dang, indent is wrong, should be 2-space:

 for (uint i = 0; i < node_max; i++) {
   ::new (&_node_bundling_base[i]) Bundle();
 }

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20181207/31988a48/signature.asc>


More information about the hotspot-compiler-dev mailing list