RFR: 8204289: AARCH64: enable math intrinsics usage in interpreter and C1

Andrew Haley aph at redhat.com
Thu Jun 21 16:30:06 UTC 2018


On 06/20/2018 03:45 PM, Dmitrij Pochepko wrote:
> webrev: http://cr.openjdk.java.net/~dpochepk/8204289/webrev.01/
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8204289

Looks OK, but...  What is the conditional code in

 270   case Interpreter::java_lang_math_log :
 271     if (StubRoutines::dlog() == NULL) {
 272       fn = CAST_FROM_FN_PTR(address, SharedRuntime::dlog);
 273     } else {
 274       fn = CAST_FROM_FN_PTR(address, StubRoutines::dlog());
 275     }

for?  When would StubRoutines::dlog() be NULL?  We don't pay any attention
to vmIntrinsics::is_intrinsic_available(), so AFAICS it's always there.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-compiler-dev mailing list