RFR: 8204289: AARCH64: enable math intrinsics usage in interpreter and C1

Dmitrij Pochepko dmitrij.pochepko at bell-sw.com
Thu Jun 21 18:06:55 UTC 2018


Thanks for noticing it. I now think it make sense to add 
vmIntrinsics::is_intrinsic_available check for math intrinsics in this 
patch. It will make it aligned with other architecture like this: 
http://cr.openjdk.java.net/~dpochepk/8204289/webrev.02/

What do you think about it?

Thanks,

Dmitrij

On 21.06.2018 19:30, Andrew Haley wrote:
> On 06/20/2018 03:45 PM, Dmitrij Pochepko wrote:
>> webrev: http://cr.openjdk.java.net/~dpochepk/8204289/webrev.01/
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8204289
> Looks OK, but...  What is the conditional code in
>
>   270   case Interpreter::java_lang_math_log :
>   271     if (StubRoutines::dlog() == NULL) {
>   272       fn = CAST_FROM_FN_PTR(address, SharedRuntime::dlog);
>   273     } else {
>   274       fn = CAST_FROM_FN_PTR(address, StubRoutines::dlog());
>   275     }
>
> for?  When would StubRoutines::dlog() be NULL?  We don't pay any attention
> to vmIntrinsics::is_intrinsic_available(), so AFAICS it's always there.
>



More information about the hotspot-compiler-dev mailing list