RFR: 8205694: AArch64: Add test to validate volatile load, store and CAS code generation

[Andrew Haley]

On 06/26/2018 05:55 PM, Andrew Dinn wrote:
>   webrev: http://cr.openjdk.java.net/~adinn/8205694/webrev.00/
>   JIRA: https://bugs.openjdk.java.net/browse/JDK-8205694

Yowza.

OK, so that wasn't a proper review.  This looks great, and pretty
thorough.  I'm sure there are still some ways in which the logic might
fail and not be caught, but this should get the obvious ones.

I don't much like the assert() rathern than guarantee() for the
failures in C2.  Won't we just crash anyway if these asserts fail?  If
so, we might as well use guarantee().

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671