RFR: 8205694: AArch64: Add test to validate volatile load, store and CAS code generation

[Andrew Dinn]

On 26/06/18 18:10, Andrew Haley wrote:
> On 06/26/2018 05:55 PM, Andrew Dinn wrote:
>>   webrev: http://cr.openjdk.java.net/~adinn/8205694/webrev.00/
>>   JIRA: https://bugs.openjdk.java.net/browse/JDK-8205694
> 
> Yowza.
> 
> OK, so that wasn't a proper review.  This looks great, and pretty
> thorough.  I'm sure there are still some ways in which the logic might
> fail and not be caught, but this should get the obvious ones.
> 
> I don't much like the assert() rathern than guarantee() for the
> failures in C2.  Won't we just crash anyway if these asserts fail?  If
> so, we might as well use guarantee().
We may not always crash if these asserts fail. However, we probably want
to because we don't know that the translation to use ldar and stlr insns
is being applied consistently. Better to crash and fix than be left
trying to track down mysterious memory bugs.

I'll fix this in an updated webrev.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander