RFR(XS): 8196294: LoopStripMiningIterShortLoop is set to zero by default

Aleksey Shipilev shade at redhat.com
Tue Mar 20 10:14:25 UTC 2018


On 03/20/2018 11:11 AM, Roland Westrelin wrote:
> 
>> Um. So there is a block in Arguments::check_vm_args_consistency():
>>
>>   if (FLAG_IS_DEFAULT(LoopStripMiningIterShortLoop)) {
>>     // blind guess
>>     LoopStripMiningIterShortLoop = LoopStripMiningIter / 10;
>>   }
>>
>> Is that block misplaced? Should be removed, if we init this per-GC? Or, it should be moved somewhere
>> after GC argument initializations?
> 
> Right. We can move it after GC initialization code so there's no
> duplicate code:
> 
> http://cr.openjdk.java.net/~roland/8196294/webrev.01/

Yes, that makes much more sense, and it covers the Shenandoah case too. Thanks! Looks good.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180320/a0d7fc74/signature.asc>


More information about the hotspot-compiler-dev mailing list