RFR(XS): 8196294: LoopStripMiningIterShortLoop is set to zero by default

Tobias Hartmann tobias.hartmann at oracle.com
Tue Mar 20 10:16:50 UTC 2018


Hi Roland,

looks good to me but I would prefer using the 'getUintxVMFlag' WhitBox API method in the test (see
test/lib/sun/hotspot/WhiteBox.java).

Thanks,
Tobias

On 20.03.2018 11:11, Roland Westrelin wrote:
> 
>> Um. So there is a block in Arguments::check_vm_args_consistency():
>>
>>   if (FLAG_IS_DEFAULT(LoopStripMiningIterShortLoop)) {
>>     // blind guess
>>     LoopStripMiningIterShortLoop = LoopStripMiningIter / 10;
>>   }
>>
>> Is that block misplaced? Should be removed, if we init this per-GC? Or, it should be moved somewhere
>> after GC argument initializations?
> 
> Right. We can move it after GC initialization code so there's no
> duplicate code:
> 
> http://cr.openjdk.java.net/~roland/8196294/webrev.01/
> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list