RFR(xxs): 8200297: Build failures after JDK-8198691 (CodeHeap State Analytics)

[Aleksey Shipilev]

On 03/27/2018 04:20 PM, Thomas Stüfe wrote:
> could I please have reviews for this tiny but urgent fix to x86-32:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200297
> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8200297-builderrors-on-x86-32-after-codeheap-lucy/webrev.00/webrev/

Not sure if we want to cast to size_t, instead of selecting the format specifiers for the expressions.

Have you printed the tables before/after? Because it seems you have lost a space here ("K"/"M" goes
there in other lines):

                         here
                           |
                           v
-          ast->print("[%5d ..%5d ): "
-                    ,(SizeDistributionArray[i].rangeStart<<log2_seg_size)
-                    ,(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
+          ast->print("[" SIZE_FORMAT_W(5) ".." SIZE_FORMAT_W(5) "): "
+                    ,(size_t)(SizeDistributionArray[i].rangeStart<<log2_seg_size)
+                    ,(size_t)(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
                     );

-          ast->print("[%5d ..%5d ): "
-                    ,(SizeDistributionArray[i].rangeStart<<log2_seg_size)
-                    ,(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
+          ast->print("[" SIZE_FORMAT_W(5) ".." SIZE_FORMAT_W(5) "): "
+                    ,(size_t)(SizeDistributionArray[i].rangeStart<<log2_seg_size)
+                    ,(size_t)(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
                     );


Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180327/0611ac32/signature.asc>