RFR(xxs): 8200297: Build failures after JDK-8198691 (CodeHeap State Analytics)

[Thomas Stüfe]

New webrev:

http://cr.openjdk.java.net/~stuefe/webrevs/8200297-builderrors-on-x86-32-after-codeheap-lucy/webrev.01/webrev/

Comments inline.

On Tue, Mar 27, 2018 at 4:30 PM, Aleksey Shipilev <shade at redhat.com> wrote:

> On 03/27/2018 04:20 PM, Thomas Stüfe wrote:
> > could I please have reviews for this tiny but urgent fix to x86-32:
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8200297
> > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/
> 8200297-builderrors-on-x86-32-after-codeheap-lucy/webrev.00/webrev/
>
> Not sure if we want to cast to size_t, instead of selecting the format
> specifiers for the expressions.
>
>
Okay. Since almost all printed expressions divide by "K" and "M" which are
size_t the expression type is converted to size_t as well, so I removed the
extraneous size_t casts for those cases. Lets hope this works for all
platforms and compilers.

For the byte-size cases I kept it.

Have you printed the tables before/after? Because it seems you have lost a
> space here ("K"/"M" goes
> there in other lines):
>
>                          here
>                            |
>                            v
> -          ast->print("[%5d ..%5d ): "
> -                    ,(SizeDistributionArray[i].rangeStart<<log2_seg_size)
> -                    ,(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
> +          ast->print("[" SIZE_FORMAT_W(5) ".." SIZE_FORMAT_W(5) "): "
> +                    ,(size_t)(SizeDistributionArray[i].
> rangeStart<<log2_seg_size)
> +                    ,(size_t)(SizeDistributionArray[i].
> rangeEnd<<log2_seg_size)
>                      );
>
> -          ast->print("[%5d ..%5d ): "
> -                    ,(SizeDistributionArray[i].rangeStart<<log2_seg_size)
> -                    ,(SizeDistributionArray[i].rangeEnd<<log2_seg_size)
> +          ast->print("[" SIZE_FORMAT_W(5) ".." SIZE_FORMAT_W(5) "): "
> +                    ,(size_t)(SizeDistributionArray[i].
> rangeStart<<log2_seg_size)
> +                    ,(size_t)(SizeDistributionArray[i].
> rangeEnd<<log2_seg_size)
>                      );
>
>
Fixed.

Thanks, Thomas


>
> Thanks,
> -Aleksey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180327/ad82d48d/attachment.html>