RFR (S) 8212070: Introduce diagnostic flag to abort VM on failed JIT compilation

Tobias Hartmann tobias.hartmann at oracle.com
Fri Nov 16 08:28:51 UTC 2018


Hi Aleksey,

this looks good to me but I also prefer 'AbortVMOnCompilationFailure'.

Just noticed that the indentation in globals.hpp:2020 is wrong (also in some previous lines) and I
prefer a newline between flag definitions.

Best regards,
Tobias

On 15.11.18 22:43, Aleksey Shipilev wrote:
> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8212070
> 
> Patch:
>   http://cr.openjdk.java.net/~shade/8212070/webrev.01/
> 
> This implements the diagnostic option to abort VM early when compilation had failed. Similar patch
> proved useful in Shenandoah work to capture performance bugs due to compilation skips early. There
> is a list of tier1 tests that would fail if we turn this option on. Some of those failures probably
> indicate testbugs.
> 
> Not really married to the name for the option, suggestions welcome. It is currently
> AbortVMOnCompileFailure, as initially suggested by Vladimir. It seems to be in line with
> AbortVMOnException.
> 
> Testing: hotspot/tier1, ad-hoc tests, jdk-submit (running)
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-compiler-dev mailing list