RFR (S) 8212070: Introduce diagnostic flag to abort VM on failed JIT compilation

Aleksey Shipilev shade at redhat.com
Fri Nov 16 11:04:13 UTC 2018


Update:
  http://cr.openjdk.java.net/~shade/8212070/webrev.02/

On 11/16/2018 09:28 AM, Tobias Hartmann wrote:
> Hi Aleksey,
> 
> this looks good to me but I also prefer 'AbortVMOnCompilationFailure'.

AbortVMOnCompilationFailure it is!

> Just noticed that the indentation in globals.hpp:2020 is wrong (also in some previous lines) and I
> prefer a newline between flag definitions.

Sorry, I don't quite get this comment. I think the indentation for the flag comment is aligned with
any other flag comment in that file, including other diagnostic options. There is also a newline
around new definition.

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20181116/6dd82fd1/signature.asc>


More information about the hotspot-compiler-dev mailing list