RFR: JDK-8211219: Type inconsistency in LIRGenerator::atomic_cmpxchg(..)

Roman Kennke rkennke at redhat.com
Thu Sep 27 12:03:51 UTC 2018


We spotted this in Shenandoah land. Doesn't seem to be catastrophic, but
would be nice to fix:

In c1_LIRGenerator_x86.cpp, towards the end of
LIRGenerator::atomic_cmpxchg(..) there's this cmove:

  __ cmove(lir_cond_equal, LIR_OprFact::intConst(1),
LIR_OprFact::intConst(0),
           result, type);

which should use T_INT instead of the passed-in type.


Bug:
https://bugs.openjdk.java.net/browse/JDK-8211219
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8211219/webrev.00/

Testing: hotspot/jtreg:tier1 ok

Ok?

Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180927/e0f5ead3/signature.asc>


More information about the hotspot-compiler-dev mailing list