RFR: JDK-8211219: Type inconsistency in LIRGenerator::atomic_cmpxchg(..)

[Igor Veresov]

Looks good.

igor



> On Sep 27, 2018, at 5:03 AM, Roman Kennke <rkennke at redhat.com> wrote:
> 
> We spotted this in Shenandoah land. Doesn't seem to be catastrophic, but
> would be nice to fix:
> 
> In c1_LIRGenerator_x86.cpp, towards the end of
> LIRGenerator::atomic_cmpxchg(..) there's this cmove:
> 
>  __ cmove(lir_cond_equal, LIR_OprFact::intConst(1),
> LIR_OprFact::intConst(0),
>           result, type);
> 
> which should use T_INT instead of the passed-in type.
> 
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8211219
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8211219/webrev.00/
> 
> Testing: hotspot/jtreg:tier1 ok
> 
> Ok?
> 
> Roman
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180927/d9f3c5e6/attachment.html>