RFR: JDK-8211219: Type inconsistency in LIRGenerator::atomic_cmpxchg(..)

Erik Österlund erik.osterlund at oracle.com
Fri Sep 28 01:21:26 UTC 2018


Hi Roman,

Looks good.

Thanks,
/Erik

On 2018-09-27 14:03, Roman Kennke wrote:
> We spotted this in Shenandoah land. Doesn't seem to be catastrophic, but
> would be nice to fix:
>
> In c1_LIRGenerator_x86.cpp, towards the end of
> LIRGenerator::atomic_cmpxchg(..) there's this cmove:
>
>    __ cmove(lir_cond_equal, LIR_OprFact::intConst(1),
> LIR_OprFact::intConst(0),
>             result, type);
>
> which should use T_INT instead of the passed-in type.
>
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8211219
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8211219/webrev.00/
>
> Testing: hotspot/jtreg:tier1 ok
>
> Ok?
>
> Roman
>



More information about the hotspot-compiler-dev mailing list