RFR(XS): 8223968: Add abort type description to RTM statistic counters
Doerr, Martin
martin.doerr at sap.com
Mon Dec 9 14:06:32 UTC 2019
Hi Gustavo,
nice improvement!
I'd only make the message array static:
static const char* _abortX_desc[ABORT_STATUS_LIMIT];
+const char* RTMLockingCounters::_abortX_desc[ABORT_STATUS_LIMIT] = {
+ "abort instruction ",
+ "may succeed on retry",
+ "thread conflict ",
+ "buffer overflow ",
+ "debug or trap hit ",
+ "maximum nested depth"
+};
Please update the copyright in the test.
Best regards,
Martin
> -----Original Message-----
> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
> Sent: Montag, 9. Dezember 2019 14:10
> To: hotspot-compiler-dev at openjdk.java.net
> Cc: Doerr, Martin <martin.doerr at sap.com>; vladimir.kozlov at oracle.com
> Subject: RFR(XS): 8223968: Add abort type description to RTM statistic
> counters
>
> Hi,
>
> Could the following change be reviewed please?
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8223968
> Webrev: http://cr.openjdk.java.net/~gromero/8223968/v1/
>
> It simply adds a description to the RTM abort counters, helping to understand
> the RTM statistics output faster and better.
>
> The change touches RTM shared code and also RTM tests in order to adapt
> the
> regex to the new output format.
>
> Thanks a lot.
>
> Best regards,
> Gustavo
More information about the hotspot-compiler-dev
mailing list