RFR(XS): 8223968: Add abort type description to RTM statistic counters
    Gustavo Romero 
    gromero at linux.vnet.ibm.com
       
    Mon Dec  9 22:05:04 UTC 2019
    
    
  
Hi Martin,
On 12/09/2019 11:06 AM, Doerr, Martin wrote:
> nice improvement!
=)
Thanks for the quick review!
> I'd only make the message array static:
> static const char* _abortX_desc[ABORT_STATUS_LIMIT];
> 
> +const char* RTMLockingCounters::_abortX_desc[ABORT_STATUS_LIMIT] = {
> +  "abort instruction   ",
> +  "may succeed on retry",
> +  "thread conflict     ",
> +  "buffer overflow     ",
> +  "debug or trap hit   ",
> +  "maximum nested depth"
> +};
oh... sure. Done.
> Please update the copyright in the test.
Done.
v2:
http://cr.openjdk.java.net/~gromero/8223968/v2/
Best regards,
Gustavo
    
    
More information about the hotspot-compiler-dev
mailing list