RFR(XS): 8223968: Add abort type description to RTM statistic counters
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Dec 10 00:52:50 UTC 2019
v2 looks good to me.
Thanks,
Vladimir
On 12/9/19 2:05 PM, Gustavo Romero wrote:
> Hi Martin,
>
> On 12/09/2019 11:06 AM, Doerr, Martin wrote:
>> nice improvement!
>
> =)
>
> Thanks for the quick review!
>
>
>> I'd only make the message array static:
>> static const char* _abortX_desc[ABORT_STATUS_LIMIT];
>>
>> +const char* RTMLockingCounters::_abortX_desc[ABORT_STATUS_LIMIT] = {
>> + "abort instruction ",
>> + "may succeed on retry",
>> + "thread conflict ",
>> + "buffer overflow ",
>> + "debug or trap hit ",
>> + "maximum nested depth"
>> +};
>
> oh... sure. Done.
>
>
>> Please update the copyright in the test.
>
> Done.
>
>
> v2:
>
> http://cr.openjdk.java.net/~gromero/8223968/v2/
>
>
> Best regards,
> Gustavo
More information about the hotspot-compiler-dev
mailing list