[14] RFR (L): 8235756: C2: Merge AD instructions for DivV, SqrtV, FmaV, AddReductionV, and MulReductionV nodes
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Dec 11 23:00:08 UTC 2019
webrev.03.vsqrt_double changes include code from webrev.02.vsqrt_float
and webrev.05.vfma_double - from webrev.04.vfma_float.
Otherwise Div, Sqrt, Fma code changes are fine. Even with above mess-up.
May be you need to separate Reduction changes into a separate patch so
we can have more time to review it. It is more complex.
Thanks,
Vladimir
On 12/11/19 3:53 AM, Vladimir Ivanov wrote:
> http://cr.openjdk.java.net/~vlivanov/jbhateja/8235756/webrev.00/all/
> https://bugs.openjdk.java.net/browse/JDK-8235756
>
> Merge AD instructions for the following vector nodes:
> - DivVF/DivVD
> - SqrtVF/SqrtVD
> - FmaVF/FmaVD
> - AddReductionV*
> - MulReductionV*
>
> Individual patches:
>
> http://cr.openjdk.java.net/~vlivanov/jbhateja/8235756/webrev.00/individual
>
> Testing: tier1-4, test run on different CPU flavors (KNL, SKL, etc)
>
> Contributed-by: Jatin Bhateja <jatin.bhateja at intel.com>
> Reviewed-by: vlivanov, sviswanathan, ?
>
> Best regards,
> Vladimir Ivanov
More information about the hotspot-compiler-dev
mailing list