[13]RFR: 8226627: assert(t->singleton()) failed: must be a constant

[Jamsheed]

Hi Pengfei,

Thanks for the review!!

On 02/07/19 3:29 PM, Pengfei Li (Arm Technology China) wrote:
> Hi Jamsheed,
>
>>> webrev: http://cr.openjdk.java.net/~jcm/8226627/webrev.00/
> I see a clever implementation of using "jint_cast" and "jlong_cast" in "add_ring()" to handle +0.0/-0.0. We previously defined very similar functions "pos_finf" and "pos_dinf" [1] which are used in add_id(). Is it possible to replace these two methods to jfloat_cast and jdouble_cast and remove the duplicate code?
Done.
>
> Another nit: Please remove the trailing space in line "  if (f0 != 0.0f || f1 != 0.0f) { ".
>
> [1] http://hg.openjdk.java.net/jdk/jdk/file/5ce081828739/src/hotspot/share/opto/type.cpp#l456

Done.

updated webrev inplace.

Best regards,

Jamsheed

>
> --
> Thanks,
> Pengfei
>