[aarch64-port-dev ] RFR(S): 8216989 - CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64

Andrew Haley aph at redhat.com
Tue Mar 19 10:52:43 UTC 2019


On 3/19/19 10:04 AM, Andrew Dinn wrote:
> On AArch64 for some unexplained reason it is the stub code which
> modifies cnt, performing the decrement and address add.

That's how x86 did it back then. x86 got fixed by
http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3f281b313240

We should look at that patch *extremely* *carefully*, and make sure we've
got all the fixes. The AArch64 version is based on that code, so it will
probably have inherited its bugs.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-compiler-dev mailing list