[aarch64-port-dev ] RFR(S): 8216989 - CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64

[Andrew Dinn]

On 19/03/2019 10:52, Andrew Haley wrote:
> On 3/19/19 10:04 AM, Andrew Dinn wrote:
>> On AArch64 for some unexplained reason it is the stub code which
>> modifies cnt, performing the decrement and address add.
> 
> That's how x86 did it back then. x86 got fixed by
> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3f281b313240
> 
> We should look at that patch *extremely* *carefully*, and make sure we've
> got all the fixes. The AArch64 version is based on that code, so it will
> probably have inherited its bugs.
Ok, noted.

Dmitrij, please prepare a revised patch to re-align AArch64 with x86_64
as previously recommended and then check it is consistent with the above
commit. I'll do the same at re-review to ensure that we have two sets of
eyes on the problem.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander