RFR: 8257460: Further CompilerOracle cleanup [v3]

[Nils Eliasson]

On Mon, 30 Nov 2020 23:38:46 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move check of unknown option to slowpaths
>
> src/hotspot/share/compiler/compilerOracle.cpp line 309:
> 
>> 307: bool CompilerOracle::has_option_value(const methodHandle& method, enum CompileCommand option, T& value) {
>> 308:   enum OptionType type = option2type(option);
>> 309:   if (type == OptionType::Unknown) {
> 
> Could this be an assertion done inside option_matches_type?

I move it out to option_matches_type so that it won't affect the hot path. I did have to add an extra check to the compiler_directives_init that uses has_option_value and sent OptionType::Unknown for options that don't have a command. But better have it there than in the common path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1528