RFR: 8257460: Further CompilerOracle cleanup [v3]

[Claes Redestad]

On Tue, 1 Dec 2020 09:35:17 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> src/hotspot/share/compiler/compilerOracle.cpp line 309:
>> 
>>> 307: bool CompilerOracle::has_option_value(const methodHandle& method, enum CompileCommand option, T& value) {
>>> 308:   enum OptionType type = option2type(option);
>>> 309:   if (type == OptionType::Unknown) {
>> 
>> Could this be an assertion done inside option_matches_type?
>
> I move it out to option_matches_type so that it won't affect the hot path. I did have to add an extra check to the compiler_directives_init that uses has_option_value and sent OptionType::Unknown for options that don't have a command. But better have it there than in the common path.

Good!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1528