RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume

[Xin Liu]

On Sun, 6 Dec 2020 23:43:30 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> if users don't specify method_name in CompileCommand, hotspot will over consume a token.
>> in debug build, it may hit the assertion of type mismatch.
>
> src/hotspot/share/compiler/methodMatcher.cpp line 280:
> 
>> 278:         CompileCommand::Unknown != CompilerOracle::string_to_option(method_name)) &&
>> 279:         strstr(line + bytes_read, method_name) == NULL) {
>> 280:       error_msg = "not specify any method pattern";
> 
> "Did not specify any method pattern", perhaps?

How about "Did not specify any method name" ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1652