RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
Claes Redestad
redestad at openjdk.java.net
Mon Dec 7 00:13:11 UTC 2020
On Mon, 7 Dec 2020 00:03:29 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> src/hotspot/share/compiler/methodMatcher.cpp line 280:
>>
>>> 278: CompileCommand::Unknown != CompilerOracle::string_to_option(method_name)) &&
>>> 279: strstr(line + bytes_read, method_name) == NULL) {
>>> 280: error_msg = "not specify any method pattern";
>>
>> "Did not specify any method pattern", perhaps?
>
> How about "Did not specify any method name" ?
It was only the missing "Did " that got my attention. I guess "method name" works, too, but isn't it technically a pattern? At least it allows wildcards, such as `java.lang.Object::*`
-------------
PR: https://git.openjdk.java.net/jdk/pull/1652
More information about the hotspot-compiler-dev
mailing list